On Fri, 24 Dec 2021 at 03:39, Scott Kostyshak <skost...@lyx.org> wrote:
> On Fri, Dec 24, 2021 at 01:13:24AM +0100, Thibaut Cuvelier wrote: > > On Fri, 24 Dec 2021 at 00:57, Thibaut Cuvelier <tcuvel...@lyx.org> > wrote: > > > > > On Fri, 24 Dec 2021 at 00:50, Thibaut Cuvelier <tcuvel...@lyx.org> > wrote: > > > > > >> On Thu, 23 Dec 2021 at 22:26, Scott Kostyshak <skost...@lyx.org> > wrote: > > >> > > >>> On Thu, Dec 23, 2021 at 03:07:00PM -0500, Scott Kostyshak wrote: > > >>> > On Thu, Dec 23, 2021 at 11:36:53AM +0100, Kornel Benko wrote: > > >>> > > Am Wed, 22 Dec 2021 22:05:02 -0500 > > >>> > > schrieb Scott Kostyshak <skost...@lyx.org>: > > >>> > > > > >>> > > > On Wed, Dec 22, 2021 at 05:16:45PM +0100, Jean-Marc Lasgouttes > > >>> wrote: > > >>> > > > > Le 22/12/2021 à 16:52, Scott Kostyshak a écrit : > > >>> > > > > > On Wed, Dec 22, 2021 at 04:16:30PM +0100, Jean-Marc > Lasgouttes > > >>> wrote: > > >>> > > > > > > > >>> > > > > > > Do we have a cprotect torture test, BTW? > > >>> > > > > > > > >>> > > > > > We don't. But I could spend some time setting these up. > Just > > >>> to make > > >>> > > > > > sure, you mean examples of .lyx files that need the > cprotect > > >>> feature to > > >>> > > > > > compile without error, right? > > >>> > > > > > > >>> > > > > Yes, that would be nice. > > >>> > > > > > >>> > > > I added a test at 87bea678. I'll add more files to that > directory > > >>> > > > (autotests/export/latex/lyxbugs-resolved/cprotect) as I find > them. > > >>> > > > > > >>> > > > Scott > > >>> > > > > >>> > > From the tests there, only > > >>> > > > > >>> > export/export/latex/lyxbugs-resolved/cprotect/9313-comment-in-figure-float-caption_docbook5 > > >>> > > fails. > > >>> > > > >>> > Indeed, thanks for catching that, Kornel. Thibaut, is this an easy > fix > > >>> > or should we invert? > > >>> > > >>> Thibaut, please also check 7779-float-in-par-env.lyx. > > >>> > > >> > > >> DocBook-wise, 9313 is truly a bug (the export code thinks there is a > > >> title, but as there's just a comment and no actual title it all > breaks). > > >> 7779 is really strange, I'll have to take a deeper look to see what's > going > > >> on. > > >> > > > > > > For 7779, there is no hope, as a figure within a title does not make > sense > > > at all, so it cannot be valid DocBook under any circumstances. This one > > > should be inverted. > > > > > > > I didn't expect it would be so easy to fix, so > > c734504d3b4bac795627e1c4fa5b2e27b15e8653 should fix the validation > problem > > for 9313. Let me know if this is enough! > > Thank you for the quick fix, Thibaut! The test now passes. After your > patch though the following test now fails for me: > > export/export/docbook/basic_docbook5 > Wow, that was quite a bug that I introduced... I fixed that in 4c27a730. Thanks for noticing this!
-- lyx-devel mailing list lyx-devel@lists.lyx.org http://lists.lyx.org/mailman/listinfo/lyx-devel
