Angus Leeming <[EMAIL PROTECTED]> writes:


| WorkArea's (width, height, xpos, ypos) returned the dimensions of something 
| in between the work_area FL_OBJECT and the entire space taken up by WorkArea. 
| I think that this is wrong and have changed them to return the dimensions of 
| the entire WorkArea. As the only places these methods are called are in the 
| new LyXView::showMathToolbar, hideMathToolbar methods, I think I'm safe, 
| but...

You are removing some of the boundires... LyXView knows about
BufferView which knows about WorkArea, LyXView is not supposed to know
anything about WorkArea. (and if it already does, that can be
considered a bug)

I must also say that a special solution for Math is not completely to
my liking. IMHO it should have been a "generic" solution to add
toolbars of any kind, even the existing one. (Handling in LyXView)

-- 
        Lgb

Reply via email to