Angus Leeming wrote:
> 
> I'm not trying to make life harder for you here!!! But:

:-)

> What default do you want for bool wide? true or false?  As you have it, wide
> is undefined I think.
> 
>  FloatParams::FloatParams()
> -       : placement("htbp")
> +       : placement("htbp"), wide(false)
>  {}

ok

> Also, why store
>         string placement
> since this makes it hard (pointless) to check (p1.placement == p2.placement)

don't know, ask Lars ...
it's his stuff

> in case the order is wrong. Why not store
>         bool here;
>         bool top;
>         bool bottom;
> etc. Then your check will be easy.

dito

> +int C_FormFloatFeedbackCB(FL_OBJECT * ob, int event,
> +                           FL_Coord, FL_Coord, int, void *)
> 
> This is nice enough, but what do people think about all this feedback stuff?
> Would it be nicer as a bubble-help? This is dead easy to do with xforms 0.89
> but is a bit more convoluted for 0.88. Nonetheless, we could provide a
> wrapper for this. Shall I do so?

feel free, but you must ask yourself, this stuff is copied
from another place, and it was you who ... :-)

Herbert

Reply via email to