On Wednesday 27 February 2002 8:34 pm, Lars Gullik Bjønnes wrote:
> Michael Schmitt <[EMAIL PROTECTED]> writes:
>
> | ../../src/insets/insetgraphics.h:122: warning: member initializers for
> | `const class string InsetGraphics::graphic_label'
> | ../../src/insets/insetgraphics.h:125: warning: and `enum
> | grfx::ImageStatus InsetGraphics::cached_status_'
> | insetgraphics.C:160: warning: will be re-ordered to match
> | declaration order
> | ../../src/insets/insetgraphics.h:122: warning: member initializers for
> | `const class string InsetGraphics::graphic_label'
> | ../../src/insets/insetgraphics.h:125: warning: and `enum
> | grfx::ImageStatus InsetGraphics::cached_status_'
> | insetgraphics.C:166: warning: will be re-ordered to match
> | declaration order
>
> I thought I reported these and that they got fixed?
> (before inclusion of grfx patch)
>
> | insetgraphics.C:166: warning: base class `class Inset' should be
> | explicitly initialized in the copy constructor
> | insetgraphics.C:166: warning: base class `class SigC::Object' should
> | be explicitly initialized in the copy constructor
Thanks for these warnings.
> Is it safe to have signals in insetgraphics? Can signals be copied?
> (copy/paste what happens then to the signal)
Signals cannot be copied, but then they shouldn't be. Each new
inset has a new signal. They are only connected when a dialog is launched.
This does not copy.
FYI:
// common part to all signals
class LIBSIGC_API Signal_
{
private:
Signal_(const Signal_&);
...
}
In the graphics stuff I used a shared_ptr when passing them around to reduce
overhead. They should NOT be passed and stored by reference in case the
original signal goes out of scope.
> | GraphicsImage.C:39: warning: assignment to `unsigned int' from `double'
> | GraphicsImage.C:40: warning: assignment to `unsigned int' from `double'
> | GraphicsImageXPM.C:305: warning: comparison between signed and unsigned
> | GraphicsImageXPM.C:306: warning: comparison between signed and unsigned
> | GraphicsImageXPM.C:350: warning: comparison between signed and unsigned
> | GraphicsImageXPM.C:352: warning: comparison between signed and unsigned
> | FormForks.C:320: warning: comparison between signed and unsigned
>
> Hmm da hmm...
Will have a look.
Angus
