On Tuesday 09 April 2002 4:42 pm, Herbert Voss wrote:
> Angus Leeming wrote:
> > Now how about my rejection of your insetgraphics.C patch. What needs to
> > be done here?
>
> attaches a patch with a lot of changes:
>
> - inPixels() gives wrong values back! +/- 1 point in fact of
> rounding problems -> image borders are cropped in lyx-view
> - inBP() is a better function. you can put it into a
> namespace of GraphicParams if you like, but I think it
> belongs to lyxlength
> - enable angle values with max 5 characters. Don't know if
> we really need this maxchar-stuff (it's from Baruch).
> - other little changes from my cvs-tree
>
> Herbert
// Bound the number of input characters
-int const SCALE_MAXDIGITS = 3;
+int const SCALE_MAXDIGITS = 3; // %-value
What about 90.5 ? Ok; leave it.
diff -u -r1.6 xformsGImage.C
--- src/frontends/xforms/xformsGImage.C 8 Apr 2002 20:00:02 -0000 1.6
+++ src/frontends/xforms/xformsGImage.C 9 Apr 2002 14:35:17 -0000
@@ -261,10 +261,10 @@
// Bounds are unchanged.
return;
- int const xoffset_r = std::max(0, image_->w - params.bb.xr);
+ int const xoffset_r = image_->w - params.bb.xr;
Unsafe. Let's make sure it _can't_ crash, not that it shouldn't with sensible
use.
- // degree units.
- flimage_rotate(image_, params.angle * 10, FLIMAGE_SUBPIXEL);
+ // degree units. We get the right value from GraphicParams
+ flimage_rotate(image_, params.angle, FLIMAGE_SUBPIXEL);
+
No! Qt will use the angle itself and gimageXPM does so already.
Apart from that I think it's all pretty sensible.
Angus
