Jean-Marc Lasgouttes wrote:
> 
> 
> Hmm, I just see that the code in GraphicsImageXPM does:
> 
>         // some image magick versions use this
>         xpm_col[1].name = 0;
>         xpm_col[1].value = "opaque";
>         xpm_col[1].pixel = lyxColorHandler->colorPixel(LColor::white);
> 
> Shouldn't that be LColor::black? John, why did you choose white
> instead of black?

I would test that right away, but GraphicsImageXPM.C is badly broken in
CVS right now. Please fix that first:

source='GraphicsImageXPM.C' object='GraphicsImageXPM.lo' libtool=yes 
depfile='.deps/GraphicsImageXPM.Plo' tmpdepfile='.deps/GraphicsImageXPM.TPlo' 
depmode=gcc /bin/sh ../../config/depcomp  /bin/sh ../../libtool --mode=compile
g++ -DHAVE_CONFIG_H  -I. -I. -I../../src -I./../  -I../../boost  -isystem
/usr/X11R6/include   -g -O -Wno-non-template-friend -W -Wall -c -o
GraphicsImageXPM.lo `test -f GraphicsImageXPM.C || echo './'`GraphicsImageXPM.C
g++ -DHAVE_CONFIG_H -I. -I. -I../../src -I./../ -I../../boost -isystem
/usr/X11R6/include -g -O -Wno-non-template-friend -W -Wall -c GraphicsImageXPM.C
-Wp,-MD,.deps/GraphicsImageXPM.TPlo
GraphicsImageXPM.C: In function `static class boost::shared_ptr<grfx::Image>
grfx::ImageXPM::newImage()':
GraphicsImageXPM.C:45: cannot allocate an object of type `grfx::ImageXPM'
GraphicsImageXPM.C:45:   since the following virtual functions are abstract:
GraphicsImage.h:73:     bool grfx::Image::isDrawable() const
GraphicsImageXPM.C: In method `class grfx::Image * grfx::ImageXPM::clone()
const':
GraphicsImageXPM.C:82: cannot allocate an object of type `grfx::ImageXPM'
GraphicsImageXPM.C:82:   since type `grfx::ImageXPM' has abstract virtual
functions
GraphicsImageXPM.C: In method `void grfx::ImageXPM::clip(const grfx::Params &)':
GraphicsImageXPM.C:273: warning: comparison between signed and unsigned
*** Error code 1


Cheers,
Rob.

Reply via email to