On Sat, Dec 07, 2002 at 09:33:28PM +0000, John Levon wrote:

> Please, all, try again with this. Works for me on qt and xforms.

I guess I should mention that keys where you have to press shift to get
to them won't work because the bindings haven't been changed yet.

I'm thinking that maybe we should logic :

                // maybe user can only reach the key via shift
                if (action == LFUN_UNKNOWN_ACTION) {
                        if (state == key_modifier::shift) {
                                // check with key_modifier::none
                        }
                }
.
> -             if (action == LFUN_UNKNOWN_ACTION) {
> +             // Hmm, we didn't match any of the keysequences. See
> +             // if it's normal insertable text not already covered
> +             // by a binding
> +             if (keysym->isText() && keyseq.length() == 1) {
> +                     lyxerr[Debug::KEY] << "isText() is true, inserting." << endl;
> +                     action = LFUN_SELFINSERT;
> +             } else {

I'm worried that explicit ~S's are too unreliable  to get right in the
bindings. Removing only shift (as suggested by Lars) is perhaps a little
hacky, but should get the cases right, without the unfortunate side
effects.

JMarc, comments ?

regards
john

Reply via email to