Jean-Marc Lasgouttes wrote: > Juergen> I think this can go into 1.3 too (the patch is against > Juergen> 1.3.1cvs, but it should also apply to HEAD). > > Does this fix the problems in bug 844? The situation is rather ugly > currently and I would like a global fix.
No, I was not aware of that. It fixes a regression/logical mistake in the qt frontend wrt xforms frontend. This does not depend on bug 844 (but I think the code in bufferparams.C is anachronistic and wrong: frontends do not allow paperpackages without having A4 chosen, so the buffer should do the same. I think that this code was from an era where user could have chose the packages without chosing A4; apart from that it is an xforms specific problem. The qt frontend resets packages to none when the paperformat changes to anything different than A4. XForms should do that too). !!! But your hint lead me to another (serious) bug in qdocument. params.setPaperStuff() was not called in QDocument, so the users of 1.3.0 cannot use any other papersize than the default one AFAICS. The attached patch would fix this, but I am not shure if this should not go to the controller !!! Anyway, I think this counts as a showstopper. Jürgen.
Index: src/frontends/qt2/ChangeLog =================================================================== RCS file: /cvs/lyx/lyx-devel/src/frontends/qt2/ChangeLog,v retrieving revision 1.389.2.3 diff -u -r1.389.2.3 ChangeLog --- src/frontends/qt2/ChangeLog 2003/02/07 16:49:19 1.389.2.3 +++ src/frontends/qt2/ChangeLog 2003/02/10 17:16:04 @@ -1,3 +1,8 @@ +2003-02-10 Juergen Spitzmueller <[EMAIL PROTECTED]> + + * QDocument.C: Allow qt users actually ti use another + papersize than default (set params.paperpackage). + 2003-02-07 John Levon <[EMAIL PROTECTED]> * lyx_gui.C: delete lyxserver pipes (bug 865) Index: src/frontends/qt2/QDocument.C =================================================================== RCS file: /cvs/lyx/lyx-devel/src/frontends/qt2/QDocument.C,v retrieving revision 1.33 diff -u -r1.33 QDocument.C --- src/frontends/qt2/QDocument.C 2003/01/23 16:23:39 1.33 +++ src/frontends/qt2/QDocument.C 2003/02/10 17:16:05 @@ -331,6 +331,10 @@ margin = margin - 1; } params.paperpackage = char(margin); + + // set params.papersize from params.papersize2 + // and params.paperpackage + params.setPaperStuff(); MarginsModuleBase const * m(dialog_->marginsModule);
