On Thu, Sep 11, 2003 at 05:24:12PM +0200, Lars Gullik Bjønnes wrote:
> Andre Poenitz <[EMAIL PROTECTED]> writes:
>
> | On Thu, Sep 11, 2003 at 03:41:41PM +0200, Lars Gullik Bjønnes wrote:
> >> Andre Poenitz <[EMAIL PROTECTED]> writes:
> >>
> >> | --with-included-string
> >> | 283 ./frontends/qt2/ui/moc
> >> | 569 ./frontends/qt2/ui
> >>
> >> Did you test this now? I had to make sevral small changes to get
> >> with-included-string to work.
> >
> | Me too. But I don't have the patch at hand, just the results.
>
> Patch enclosed.
Well, I would have liked a 'using std::string' in tex2lyx/*.C better
than your explicit qualification but I can 'fix' that myself later.
> >> And it must have been non-working for several days, so are anyone
> >> really using lyxstring?
> >
> | Probably not too many...
>
> So your vote is to...?
remove lyxstring.C.
In lyxstring.h write
#include <string>
namespace lyx {
using std::string;
}
Drop STRCONV.
Note that I'd like to keep that lyx::string 'wrapper' for a while to
be (a) able to play a bit with 'class lyx::string : private std::string
{};' and (b) to keep the change small.
I do not really expect 10%+ gains from the private inheritance but I'd
like to keep that option until we've seen hard figures. After that we
could completely remove lyxstring.h. If you did the 'big jump' at once,
I'd have to un-do most of your patch in my local tree for the playing
which is a complete waste of time for me.
Andre'
--
Those who desire to give up Freedom in order to gain Security, will not have,
nor do they deserve, either one. (T. Jefferson or B. Franklin or both...)
