Lars Gullik Bj�nnes wrote:

> Trying to move along...

Hmmm. I think that you should get rid of
        DispatchResult(bool dis);

Code like this is just going to end up confusing people:

Index: src/insets/insetert.C
        case LFUN_MOUSE_RELEASE:
                lfunMouseRelease(cmd);
-               result = DispatchResult(true);
+               result = DispatchResult(true, true);
                break;

        case LFUN_LAYOUT:
                bv->owner()->setLayout(inset.paragraphs.begin()->layout()->name());
-               result = DispatchResult(true, NOUPDATE);
+               result = DispatchResult(true);
                break;

Also stuff like this still looks "unfortunate" to my eyes.
Index: src/mathed/formulabase.C
+               result = mathcursor->right(sel) ? 
                        DispatchResult(true, true) : 
                        DispatchResult(false, FINISHED_RIGHT);

I'd prefer the 'update' to be explicit
                        DispatchResult(false, false, FINISHED_RIGHT);

Incidentally, what other changes are you planning?

-- 
Angus

Reply via email to