Angus Leeming <[EMAIL PROTECTED]> writes:
| Lars Gullik Bj�nnes wrote:
>
>> Trying to move along...
>
| Hmmm. I think that you should get rid of
| DispatchResult(bool dis);
>
| Code like this is just going to end up confusing people:
perhaps... but I am taking small steps...
>
| Index: src/insets/insetert.C
| case LFUN_MOUSE_RELEASE:
| lfunMouseRelease(cmd);
| - result = DispatchResult(true);
| + result = DispatchResult(true, true);
| break;
>
| case LFUN_LAYOUT:
| bv->owner()->setLayout(inset.paragraphs.begin()->layout()->name());
| - result = DispatchResult(true, NOUPDATE);
| + result = DispatchResult(true);
| break;
>
| Also stuff like this still looks "unfortunate" to my eyes.
| Index: src/mathed/formulabase.C
| + result = mathcursor->right(sel) ?
| DispatchResult(true, true) :
| DispatchResult(false, FINISHED_RIGHT);
>
| I'd prefer the 'update' to be explicit
| DispatchResult(false, false, FINISHED_RIGHT);
perhaps...
I want its usage to be explicit.
Usually I'd want it to always be set with DispatchResult::update(bool)
| Incidentally, what other changes are you planning?
add a a unlock class unfunction.
--
Lgb
