Jean-Marc Lasgouttes wrote:
>>>>>> "Angus" == Angus Leeming <[EMAIL PROTECTED]> writes:
>
> Angus> Jean-Marc, it appears that LyX is outputting filenames from
> the Angus> graphics conversion code which are a weird mixture of
> Win32 and Angus> Unix. Stuff like 'C:/foo/bar/file.eps' should
> obviously be Angus> 'C:\foo\bar\file.eps'.
>
> Angus> The real fix is to find the problem in the LyX sources
> Angus> themselves, but the attached patch modifies convertDefault.sh
> Angus> to sanitize the file names passed to it. I'm not sure what
> you Angus> think of such a thing.
>
> My problem with it is that in only works when falling back to
> convertDefault.sh. I guess similar problems can also occur when
> using real converters...
>
> Does the problem occur with cygwin, or only mingw? In the former
> case, you may want to ask kayvan for help, but in the later it will
> not be useful to fix anything unless you manage to contact Ruurd
> (who is the only one who knows about those native windows releases);
> I do not know whether he plans to continue making his releases.
Ruurd has certainly gone quiet on us.
Kayvan has implemented the most attrocious hack that I suspect is the
real cause of our problems under mingw. This is from os_win32.C:
string os::external_path(string const & p) {
string dos_path=p;
if (is_absolute_path(p)) {
char dp[255];
cygwin_conv_to_full_win32_path(p.c_str(), dp);
dos_path=subst(dp,'\\','/');
}
return dos_path;
}
Cygwin is clever enough to untangle the mess. I'd prefer that we fixed
things properly but am still unclear why Kayvan found it to be
necessary in the first place. (He did explain, but I failed to follow
the argument.)
> There is also something that I do not like much: the '-depth 8'
> argument. I think it means we output degraded images, even in
> printed versions.
This survives from Herbert's earliest versions of the script. I have
vague memories that people were reporting 'convert' failures and that
the '-depth 8' argument proved to be a robust fix.
In light of this, what do you think we should do with it?
--
Angus
