Jean-Marc Lasgouttes wrote:
> If you look at the following patch:
> http://www.home.zonnet.nl/rareitsma/lyx/lyx_win32.diff

I think it's about time that we merged this patch into the 1.4.x tree.

> You see that Ruurd has added an explicit:
> +     //No backslashes in LaTeX files
> +     dos_path = subst(dos_path,'\\','/');
> 
> This is probably the problem. Is it true that latex does not want
> backslashes in file names?

How would I know ;-)
Assuming that this is indeed the case, then we should differentiate 
between external_path(p) and external_path_suitable_for_latex(p):

string os::external_path_suitable_for_latex(string const & p) {
        string const dos_path = external_path(p);
        // No backslashes in LaTeX files
        return subst(dos_path,'\\','/');
}

>>> There is also something that I do not like much: the '-depth 8'
>>> argument.
> Angus> In light of this, what do you think we should do with it?
> I'd be tempted to remove it... I guess it was needed by the
> xpm-based image loader (maybe as a speedup). We could at least
> remove it in 1.4.0cvs and see what happens.

I'll do that with pleasure.

-- 
Angus

Reply via email to