Jean-Marc Lasgouttes wrote:
> Angus> So, getFromLyXName is simply adding a new entry to the
> Angus> map<name, #rrggbb> used to store these colours. What is so
> Angus> confusing about that?
> 
> No, it adds a new entry which has a lyxname, but no x11 value or
> anything:
> 
> void LColor::addColor(LColor::color c, string const & lyxname) const
> {
> ColorEntry ce = { c, "", "", "", lyxname.c_str() };
> pimpl_->fill(ce);
> }
> 
> So, while it says that it succeeded, any code that tries to
> translate a broken color name will be given a brand new unusable
> color and never be warned of this fact. This is rude.

So, initialize the ColorEntry to black or somesuch...

Alternatively, describe an improved scheme.

-- 
Angus

Reply via email to