On Tue, Mar 16, 2004 at 04:39:02PM +0000, Angus Leeming spake thusly:
>
> Jean-Marc Lasgouttes wrote:
> > Angus> So, getFromLyXName is simply adding a new entry to the
> > Angus> map<name, #rrggbb> used to store these colours. What is so
> > Angus> confusing about that?
> >
> > No, it adds a new entry which has a lyxname, but no x11 value or
> > anything:
> >
> > void LColor::addColor(LColor::color c, string const & lyxname) const
> > {
> > ColorEntry ce = { c, "", "", "", lyxname.c_str() };
> > pimpl_->fill(ce);
> > }
> >
> > So, while it says that it succeeded, any code that tries to
> > translate a broken color name will be given a brand new unusable
> > color and never be warned of this fact. This is rude.Uh, it *does* give an error message... which could no doubt be made clearer still. > So, initialize the ColorEntry to black or somesuch... More logical would be "background". > Alternatively, describe an improved scheme. > > -- > Angus - Martin
pgp00000.pgp
Description: PGP signature
