On Tue, May 09, 2006 at 10:27:17PM +0200, Michael Gerz wrote:
> case LFUN_CHANGE_REJECT: // what about these two
> case LFUN_ALL_CHANGES_ACCEPT:
> case LFUN_ALL_CHANGES_REJECT:
> - flag.enabled(buffer_ && buffer_->params().tracking_changes);
> + flag.enabled(buffer_);
Will there be a plan to re-enable the test at some point? I.E. are you
going to make "there are unaccepted changes" an O(1) operation on the
buffer?
> - if (features.isAvailable("dvipost") && params().tracking_changes
> - && params().output_changes)
> + if (features.isAvailable("dvipost") && params().output_changes)
> features.require("dvipost");
What does the UI for these two options look like?
> // Are we in a DELETED change-tracking region?
> - if (buf && buf->params().tracking_changes
> - && lookupChangeType(cur, true) == Change::DELETED
> + if (buf && lookupChangeType(cur, true) == Change::DELETED
Presumably this is or is going to be a fast operation now?
regards
john
