Abdelrazak Younes <[EMAIL PROTECTED]> writes:

| Abdelrazak Younes a écrit :
| > Bo, it's an updated patch from yours, you might want to take
| > ownership of this as it contains your changes to Scons also.
| > The improvement in compilation time is even more sensible with
| > autotools than with scons. I'd say the 30%/40% improvement is a good
| > estimate.
| > I'd like to put this in (or Bo), any objection against that patch?
| 
| As there seems to be no objection, I am going to commit that. I'll
| appreciate nevertheless a review of ma change in Makefile.am:
| 
| > Index: src/frontends/qt4/Makefile.am
| > ===================================================================
| > --- src/frontends/qt4/Makefile.am   (revision 13852)
| > +++ src/frontends/qt4/Makefile.am   (working copy)
| > @@ -1,16 +1,25 @@
| >  include $(top_srcdir)/config/common.am
| >  include $(srcdir)/Makefile.dialogs
| >  -SUBDIRS = ui moc
| > +DISTCLEANFILES += *_moc.cpp
| >  +libqt4_la_DEPENDENCIES = $(MOCEDFILES)
| > +
| > +MOCEDFILES = $(MOCFILES:.C=_moc.cpp)
| > +
| > +%_moc.cpp: %.h
| > +   $(MOC4) -o $@ $<
| > +
| > +SUBDIRS = ui
| > +
| >  EXTRA_DIST = pch.h Makefile.dialogs
| >  -BUILT_SOURCES = $(PCH_FILE)
| > +BUILT_SOURCES = $(PCH_FILE) $(MOCEDFILES)
| >   noinst_LTLIBRARIES = libqt4.la
| >   libqt4_la_LDFLAGS = $(QT4_LDFLAGS)
| > -libqt4_la_LIBADD = $(QT4_LIB) moc/*.lo +libqt4_la_LIBADD =
| > $(QT4_LIB)  AM_CPPFLAGS += \
| >     $(QT4_CPPFLAGS) \
| >     $(PCH_FLAGS) \

Can you move the SUBDIRS var back to the top of the file pleae.
Also EXTRA_DIST should be at the top.

-- 
        Lgb

Reply via email to