Georg Baum wrote: > Am Samstag, 17. Juni 2006 18:55 schrieb Juergen Spitzmueller: > > I intend to shove this into trunk on Monday unless I get objections. > > I found some minor problems in lyx2lyx. A corrected version can be found > in l.diff. > > I also implemented quick and dirty gtk support and fixed some copy/paste > errors (see x.diff, contains everything in src/frontends, but does not > contain the new files). I also put the default font families in a common > place, this makes the code simpler and avoids repetition. Finally I used > lyx::support::findToken where appropriate, this does also save some > lines.
Thanks for the very close review, this was all very helpful. I made a diff of the diffs and intergrated your changes. > Is there a reason why the sc and tt scales are integers? If that is not a > LaTeX restriction I would like floating point values instead. On the LaTeX side, this doesn't matter (we have to calculate floats for the scale options anyway). The reason is that we do not use floats for any other bufferparam, and I seem to remember that Lars was strongly objecting against doing so. > Finally you need to update development/FORMAT. Done. > Georg
