Am Sonntag, 25. Juni 2006 19:41 schrieb Juergen Spitzmueller:
> Very good, thanks. However, I think the "default" switches should be 
disabled 
> initially at least for non-booktabs tables. It looks rather odd for 
those (on 
> screen and output).

Only bottom_space makes sense for non booktab tables IMO. I implemented 
the others because it was easier for me than a logic for 
enabling/disabling them. Feel free to change that.

> Also there are accelerators missing for the default checks (and some 
> duplicated accelerators for _T_op Space/_T_able Settings and _B_ottom 
> Space/_B_orders). 
> Attached is a patch for the gui issues issues, which I'll shove in.
> 
> > Known problems: qt4 crashes if you want to change the spaces, I don't 
know
> > why.
> 
> There's a cut'n'paste error in QDialog.C (see attached patch). That was 
> obviously one cause. Now it only crashes if you insert bogus data 
(like "r") 
> to the fields. I guess it needs a proper input validator.

Thanks, it is really too easy to overlook ones own mistakes.
The length fields do use length validators. Why does it not work?

> Well, for my usual work with booktabs, one important feature would be 
missing: 
> Proper support for \cmidrule (i.e. ability to use something like 
> \cmidrule(l){2-3}\cmidrule(lr){4-4}\cmidrule(r){5-6}
> ). I'm not sure how the UI for this might look like, though.

That is indeed difficult. What about adding short lines to the left and 
right of the bottom and top line of the border widget that can be set and 
unset? E.g

- ------ -

whould give \cmidrule{2-2}, and

  ------ -

would give \cmidrule(l){2-2} etc.

rules would be combined if the short lines inbetween are set, e.g.

- ------ -

both in cell 2 and 3 would give \cmidrule{2-3}.


BTW the spaces should ideally be incorporated into the border widget, 
because then it is clear what they do.


Georg

Reply via email to