On Mon, Jun 26, 2006 at 06:43:04PM +0200, Jean-Marc Lasgouttes wrote:
> >>>>> "Georg" == Georg Baum <[EMAIL PROTECTED]> writes:
>
> Georg> Jean-Marc Lasgouttes wrote:
> >> It looks correct to me, although I did not try it out. Georg, what
> >> do you think?
>
> Georg> I did not look at the patch. I spent far too much time with
> Georg> this stuff already, so I decided to have no opinion.
>
> Enrico, I propose that you apply it to 1.5 now (minus the
> compatibility code for the old variable which is not really needed, I
> think).
I do not have commit privileges, so some kind soul should apply it.
I mostly agree with you about the compatibility code, as lyxrc.defaults
is automatically regenerated after an upgrade. But if someone changed
the default, the old switch would be also in preferences and will not
be recognized. I think that the compatibility code could be left in 1.4.x
but removed in 1.5.x. After all, this code reduces to the following in
src/lyxrc.C:
+ // compatibility with versions older than 1.4.2 only
+ { "\\cygwin_path_fix_needed", LyXRC::RC_TEX_EXPECTS_WINDOWS_PATHS },
I'll prepare an updated patch, though.
> Then I would appreciate a 1.4.2 version, if you believe this is needed
> for proper cygwin operation.
Yes, I think that the fix about external_path is really needed, as it
cannot depend on the checkbutton status. Then, the meaning of the switch
is now more clear, I think.
I'll also put together a patch for 1.4.2.
--
Enrico
