Georg Baum wrote:
I'll commit an updated one tonight.
I have a lot of warning following the patch using MSVC. Should we fix
them? I guess most of them will be fixed once the code is ported to
char_type and docstring. I list them here for reference:
..\..\..\trunk\src\insets\insetcollapsable.C(258) : warning C4244:
'argument' : conversion from 'Paragraph::value_type' to 'char', possible
loss of data
..\..\..\trunk\src\graphics\PreviewImage.C(59) : warning C4355: 'this' :
used in base member initializer list
D:\devel\lyx\trunk\src\lyxserver.h(113) : warning C4355: 'this' : used
in base member initializer list
Copy of qt_helpers.obj : warning LNK4006: "class
std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > __cdecl makeFontName(class
std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > const &,class std::basic_string<char,struct
std::char_traits<char>,class std::allocator<char> > const &)"
(?makeFontName@@[EMAIL PROTECTED]@[EMAIL PROTECTED]@@[EMAIL PROTECTED]@2@@std@@[EMAIL PROTECTED]@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "class QString const __cdecl
toqstr(char const *)" (?toqstr@@YA?BVQString@@[EMAIL PROTECTED]) already defined in
qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "class QString const __cdecl
toqstr(class std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > const &)"
(?toqstr@@YA?BVQString@@[EMAIL PROTECTED]@[EMAIL PROTECTED]@@[EMAIL PROTECTED]@2@@std@@@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "unsigned long const __cdecl
qchar_to_ucs4(class QChar const &)" (?qchar_to_ucs4@@YA?BKABVQChar@@@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "class QChar const __cdecl
ucs4_to_qchar(unsigned long const &)"
(?ucs4_to_qchar@@YA?BVQChar@@[EMAIL PROTECTED]) already defined in qt_helpers.obj;
second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "class QString const __cdecl
qt_(char const *)" (?qt_@@YA?BVQString@@[EMAIL PROTECTED]) already defined in
qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "class QString const __cdecl
qt_(class std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > const &)"
(?qt_@@YA?BVQString@@[EMAIL PROTECTED]@[EMAIL PROTECTED]@@[EMAIL PROTECTED]@2@@std@@@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "class
std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > const __cdecl fromqstr(class QString const &)"
(?fromqstr@@[EMAIL PROTECTED]@[EMAIL PROTECTED]@@[EMAIL PROTECTED]@2@@std@@ABVQString@@@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "class
std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > __cdecl widgetsToLength(class QLineEdit const
*,class LengthCombo const *)"
(?widgetsToLength@@[EMAIL PROTECTED]@[EMAIL PROTECTED]@@[EMAIL PROTECTED]@2@@std@@PBVQLineEdit@@PBVLengthCombo@@@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "class LyXLength __cdecl
widgetsToLength(class QLineEdit const *,class QComboBox const *)"
(?widgetsToLength@@YA?AVLyXLength@@PBVQLineEdit@@PBVQComboBox@@@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "void __cdecl
lengthToWidgets(class QLineEdit *,class LengthCombo *,class
std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > const &,enum LyXLength::UNIT)"
(?lengthToWidgets@@YAXPAVQLineEdit@@PAVLengthCombo@@[EMAIL PROTECTED]@[EMAIL PROTECTED]@@[EMAIL PROTECTED]@2@@std@@[EMAIL PROTECTED]@@@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "class QString const __cdecl
ucs4_to_qstring(unsigned long const *,unsigned int)"
(?ucs4_to_qstring@@YA?BVQString@@[EMAIL PROTECTED]) already defined in
qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "class QString const __cdecl
ucs4_to_qstring(class std::vector<unsigned long,class
std::allocator<unsigned long> > const &)"
(?ucs4_to_qstring@@YA?BVQString@@[EMAIL PROTECTED]@[EMAIL PROTECTED]@@@std@@@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "class
std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > const __cdecl formatted(class
std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> > const &,int)"
(?formatted@@[EMAIL PROTECTED]@[EMAIL PROTECTED]@@[EMAIL PROTECTED]@2@@std@@[EMAIL PROTECTED]@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "struct std::pair<class
std::basic_string<char,struct std::char_traits<char>,class
std::allocator<char> >,class std::basic_string<char,struct
std::char_traits<char>,class std::allocator<char> > > __cdecl
parseFontName(class std::basic_string<char,struct
std::char_traits<char>,class std::allocator<char> > const &)"
(?parseFontName@@[EMAIL PROTECTED]@[EMAIL PROTECTED]@std@@[EMAIL PROTECTED]@2@@std@@V12@@std@@[EMAIL PROTECTED]@[EMAIL PROTECTED]@@[EMAIL PROTECTED]@2@@2@@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "class std::vector<unsigned
long,class std::allocator<unsigned long> > __cdecl qstring_to_ucs4(class
QString const &)"
(?qstring_to_ucs4@@[EMAIL PROTECTED]@[EMAIL PROTECTED]@@@std@@ABVQString@@@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4006: "void __cdecl
qstring_to_ucs4(class QString const &,class std::vector<unsigned
long,class std::allocator<unsigned long> > &)"
(?qstring_to_ucs4@@YAXABVQString@@[EMAIL PROTECTED]@[EMAIL PROTECTED]@@@std@@@Z)
already defined in qt_helpers.obj; second definition ignored
Copy of qt_helpers.obj : warning LNK4221: no public symbols found;
archive member will be inaccessible
..\..\..\..\trunk\src\frontends\controllers\ControlSpellchecker.C(165) :
warning C4244: 'argument' : conversion from 'const
Paragraph::value_type' to 'char', possible loss of data
..\..\..\..\trunk\src\frontends\controllers\ControlSpellchecker.C(166) :
warning C4244: 'argument' : conversion from 'const
Paragraph::value_type' to 'unsigned char', possible loss of data
D:\devel\lyx\trunk\src\support/lstrings.h(96) : warning C4244:
'argument' : conversion from 'Paragraph::value_type' to 'char', possible
loss of data
..\..\..\..\trunk\src\frontends\controllers\ControlSpellchecker.C(138) :
see reference to function template instantiation 'bool
lyx::support::contains<Paragraph::value_type>(const std::string &,B)'
being compiled
with
[
B=Paragraph::value_type
]
..\..\..\..\trunk\src\frontends\controllers\biblio.C(466) : warning
C4101: 'regerr' : unreferenced local variable
BCView.C
..\..\..\trunk\src\mathed\math_nestinset.C(928) : warning C4244:
'argument' : conversion from 'const unsigned long' to 'char', possible
loss of data
..\..\trunk\intl\dcigettext.c(1005) : warning C4116: unnamed type
definition in parentheses
..\..\trunk\intl\dcigettext.c(1006) : warning C4116: unnamed type
definition in parentheses
..\..\trunk\intl\loadmsgcat.c(940) : warning C4013: 'open' undefined;
assuming extern returning int
..\..\trunk\intl\loadmsgcat.c(955) : warning C4013: 'close' undefined;
assuming extern returning int
..\..\trunk\intl\loadmsgcat.c(988) : warning C4013: 'read' undefined;
assuming extern returning int
..\..\..\..\trunk\boost\libs\regex\src\cregex.cpp(568) : warning C4309:
'static_cast' : truncation of constant value
d:\devel\lyx\trunk\src\aspell_local.h(20) : warning C4099:
'AspellSpeller' : type name first seen using 'struct' now seen using 'class'
D:\program\gnuwin32\include\aspell.h(355) : see declaration of
'AspellSpeller'
d:\devel\lyx\trunk\src\aspell_local.h(21) : warning C4099:
'AspellStringEnumeration' : type name first seen using 'struct' now seen
using 'class'
D:\program\gnuwin32\include\aspell.h(549) : see declaration of
'AspellStringEnumeration'
d:\devel\lyx\trunk\src\aspell_local.h(22) : warning C4099:
'AspellCanHaveError' : type name first seen using 'struct' now seen
using 'class'
D:\program\gnuwin32\include\aspell.h(219) : see declaration of
'AspellCanHaveError'
d:\devel\lyx\trunk\src\aspell_local.h(23) : warning C4099:
'AspellConfig' : type name first seen using 'struct' now seen using 'class'
D:\program\gnuwin32\include\aspell.h(89) : see declaration of
'AspellConfig'
..\..\trunk\src\text3.C(952) : warning C4244: 'argument' : conversion
from 'lyx::char_type' to 'char', possible loss of data
..\..\trunk\src\text3.C(956) : warning C4244: 'argument' : conversion
from 'lyx::char_type' to 'char', possible loss of data
..\..\trunk\src\text3.C(1414) : warning C4244: 'argument' : conversion
from 'const unsigned long' to 'char', possible loss of data
text2.C
text.C
..\..\trunk\src\text.C(454) : warning C4244: 'argument' : conversion
from 'LyXText::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\text.C(460) : warning C4244: 'argument' : conversion
from 'LyXText::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\text.C(464) : warning C4244: 'argument' : conversion
from 'LyXText::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\text.C(1201) : warning C4244: 'argument' : conversion
from 'LyXText::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\text.C(1209) : warning C4244: 'argument' : conversion
from 'LyXText::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\text.C(1238) : warning C4244: 'argument' : conversion
from 'LyXText::char_type' to 'char', possible loss of data
..\..\trunk\src\text.C(1627) : warning C4244: 'argument' : conversion
from 'LyXText::char_type' to 'char', possible loss of data
..\..\trunk\src\text.C(1630) : warning C4244: 'argument' : conversion
from 'LyXText::char_type' to 'char', possible loss of data
..\..\trunk\src\text.C(1634) : warning C4244: 'argument' : conversion
from 'LyXText::char_type' to 'char', possible loss of data
d:\devel\lyx\trunk\src\support/lstrings.h(96) : warning C4244:
'argument' : conversion from 'LyXText::char_type' to 'char', possible
loss of data
..\..\trunk\src\text.C(1201) : see reference to function
template instantiation 'bool
lyx::support::contains<LyXText::char_type>(const std::string &,B)' being
compiled
with
[
B=LyXText::char_type
]
..\..\trunk\src\rowpainter.C(200) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'char', possible loss of data
..\..\trunk\src\rowpainter.C(208) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\rowpainter.C(209) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\rowpainter.C(235) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'char', possible loss of data
..\..\trunk\src\rowpainter.C(243) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\rowpainter.C(244) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\rowpainter.C(290) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\rowpainter.C(293) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\rowpainter.C(296) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\rowpainter.C(367) : warning C4244: 'argument' :
conversion from 'const lyx::char_type' to 'unsigned char', possible loss
of data
..\..\trunk\src\rowpainter.C(368) : warning C4244: 'argument' :
conversion from 'const lyx::char_type' to 'unsigned char', possible loss
of data
..\..\trunk\src\rowpainter.C(771) : warning C4244: 'initializing' :
conversion from 'Paragraph::value_type' to 'const unsigned char',
possible loss of data
..\..\trunk\src\paragraph.C(657) : warning C4244: '=' : conversion from
'unsigned long' to 'char', possible loss of data
..\..\trunk\src\paragraph.C(661) : warning C4244: '=' : conversion from
'unsigned long' to 'char', possible loss of data
..\..\trunk\src\paragraph.C(1179) : warning C4244: 'argument' :
conversion from 'Paragraph::value_type' to 'char', possible loss of data
..\..\trunk\src\paragraph.C(1242) : warning C4244: 'argument' :
conversion from 'Paragraph::value_type' to 'char', possible loss of data
..\..\trunk\src\paragraph.C(1273) : warning C4244: 'argument' :
conversion from 'const Paragraph::value_type' to 'char', possible loss
of data
..\..\trunk\src\paragraph.C(1286) : warning C4244: 'argument' :
conversion from 'const Paragraph::value_type' to 'unsigned char',
possible loss of data
..\..\trunk\src\paragraph.C(1286) : warning C4244: 'argument' :
conversion from 'const Paragraph::value_type' to 'unsigned char',
possible loss of data
..\..\trunk\src\paragraph.C(1398) : warning C4244: 'argument' :
conversion from 'const Paragraph::value_type' to 'unsigned char',
possible loss of data
..\..\trunk\src\paragraph.C(1615) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\paragraph.C(1616) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\paragraph.C(1626) : warning C4244: 'argument' :
conversion from 'const Paragraph::value_type' to 'unsigned char',
possible loss of data
..\..\trunk\src\paragraph.C(1632) : warning C4244: 'argument' :
conversion from 'Paragraph::value_type' to 'unsigned char', possible
loss of data
..\..\trunk\src\paragraph.C(1633) : warning C4244: 'argument' :
conversion from 'const Paragraph::value_type' to 'unsigned char',
possible loss of data
..\..\trunk\src\paragraph.C(1634) : warning C4244: 'argument' :
conversion from 'const Paragraph::value_type' to 'unsigned char',
possible loss of data
..\..\trunk\src\paragraph.C(1635) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\paragraph.C(1637) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\paragraph.C(1639) : warning C4244: 'argument' :
conversion from 'const Paragraph::value_type' to 'unsigned char',
possible loss of data
..\..\trunk\src\paragraph.C(1640) : warning C4244: 'argument' :
conversion from 'const Paragraph::value_type' to 'unsigned char',
possible loss of data
..\..\trunk\src\paragraph.C(1641) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of data
..\..\trunk\src\paragraph.C(1643) : warning C4244: 'argument' :
conversion from 'lyx::char_type' to 'unsigned char', possible loss of
..\..\trunk\src\mover.C(82) : warning C4172: returning address of local
variable or temporary
d:\devel\lyx\trunk\src\lyxserver.h(113) : warning C4355: 'this' : used
in base member initializer list
..\..\trunk\src\lyxfunc.C(218) : warning C4244: 'initializing' :
conversion from 'lyx::char_type' to 'char', possible loss of data
..\..\trunk\src\lyxfind.C(79) : warning C4244: 'argument' : conversion
from 'Paragraph::value_type' to 'char', possible loss of data
..\..\trunk\src\encoding.C(344) : warning C4244: '=' : conversion from
'long' to 'Uchar', possible loss of data
..\..\trunk\src\DepTable.C(65) : warning C4244: '=' : conversion from
'time_t' to 'long', possible loss of data
D:\devel\lyx\trunk\boost\boost/test/utils/nullstream.hpp(84) : warning
C4355: 'this' : used in base member initializer list
D:\devel\lyx\trunk\boost\boost/test/utils/nullstream.hpp(84) :
while compiling class template member function
'boost::basic_onullstream<CharType>::basic_onullstream(void)'
with
[
CharType=char
]
d:\devel\lyx\trunk\src\support/debugstream.h(103) : see
reference to class template instantiation
'boost::basic_onullstream<CharType>' being compiled
with
[
CharType=char
]
d:\devel\lyx\trunk\src\debug.h(115) : see reference to class
template instantiation 'basic_debugstream<dtrait>' being compiled
with
[
dtrait=lyx_debug_trait
]
CutAndPaste.C
..\..\trunk\src\CutAndPaste.C(678) : warning C4146: unary minus operator
applied to unsigned type, result still unsigned
cursor_slice.C
cursor.C
..\..\trunk\src\cursor.C(672) : warning C4244: 'argument' : conversion
from 'lyx::char_type' to 'char', possible loss of data