> On Dec 14, 2014, at 11:59 AM, khindenb...@macports.org wrote:
>
> Revision
> 129502
> Author
> khindenb...@macports.org
> Date
> 2014-12-14 09:59:07 -0800 (Sun, 14 Dec 2014)
> Log Message
>
> lastpass-cli: new port #45578 (and #45886)
> Added Paths
>
> • trunk/dports/security/lastpass-cli/
> • trunk/dports/security/lastpass-cli/Portfile
> Diff
>
> Added: trunk/dports/security/lastpass-cli/Portfile (0 => 129502)
>
> --- trunk/dports/security/lastpass-cli/Portfile
> (rev 0)
> +++ trunk/dports/security/lastpass-cli/Portfile 2014-12-14 17:59:07 UTC
> (rev 129502)
>
> @@ -0,0 +1,55 @@
>
> +# # -*- coding: utf-8; mode: tcl; tab-width: 4; indent-tabs-mode: nil;
> c-basic-offset: 4 -*- vim:fenc=utf-8:ft=tcl:et:sw=4:ts=4:sts=4
> +# $Id$
> +
> +PortSystem 1.0
> +PortGroup github 1.0
> +
> +github.setup lastpass lastpass-cli 0.4.0 v
> +
> +categories security
> +platforms darwin
> +maintainers gmail.com:israelchauca oaf.dk:mni khindenburg
> openmaintainer
> +license GPL-2
> +supported_archs noarch
> +
> +description C99 command line interface to LastPass.com
I would remove "C99" from the description; I don't think anyone reading the
description of a port cares what flavor of what programming language it was
written in.
> +subport ${name}-pinentry {
> + description-append using pinentry
> + long_description-append using pinentry
> +
> + conflicts ${name}
> + depends_lib-append port:pinentry
> +}
This doesn't look sufficient. If pinentry support is automatically included
simply because pinentry is installed, then the main (non-pinentry) port needs
to be fixed not to use pinentry even if it is already installed.
Moreover, it seems strange to implement this as a subport instead of a variant.
Unless a subport is a -devel subport, it's not supposed to conflict with the
main port. Variants are typically used to enable optional features; pinentry
support thus seems like a natural fit for a variant. What is the implication of
having lastpass-cli built with pinentry support? I'm not really clear on what
pinentry is.
_______________________________________________
macports-dev mailing list
macports-dev@lists.macosforge.org
https://lists.macosforge.org/mailman/listinfo/macports-dev
