Thanks Joshua. On Wed, Aug 13, 2025 at 7:04 AM Joshua Root <[email protected]> wrote:
> Hi Enrico, > > On 13/8/2025 07:56, Enrico Maria Crisostomo wrote: > > Folks, > > > > This is embarrassing, but I've unwillingly pushed what should have been > > an update branch ready for a PR directly onto master (root cause: bug in > > a script I used). The commit is https://github.com/macports/macports- > > ports/commit/dec043893a250626d8f08b76b2f6d17ad30406d0 <https:// > > github.com/macports/macports-ports/commit/ > > dec043893a250626d8f08b76b2f6d17ad30406d0> > > > > I've reverted it, apologies for the noise in master. > No worries, mistakes happen. :) > > There's actually no rule against pushing directly to master for ports > you maintain, or minor updates to openmaintainer ports. But of course if > you want to make sure your changes pass CI, or give the opportunity for > others to review them, opening a PR is also perfectly valid. > > Also be aware that changes on master are queued on the buildbot > immediately, so binaries for docker-credential-helpers 0.9.3 were built > and deployed from the initial commit. So if you find that additional > changes that affect the installed files are needed, make sure you also > bump the revision when you push the modified update. > The PR I then created was all green so this port is fine as is. Cheers, Enrico > > - Josh >
