Reviewed: https://reviews.mahara.org/2666 Committed: http://gitorious.org/mahara/mahara/commit/cd684a971df5d60b1c1e91171e683aa4b23f49bb Submitter: Son Nguyen (son.ngu...@catalyst.net.nz) Branch: 1.7_STABLE
commit cd684a971df5d60b1c1e91171e683aa4b23f49bb Author: Son Nguyen <s...@catalyst.net.nz> Date: Thu Oct 17 21:43:07 2013 +1300 Fix blocks lost when importing leap2a (Bug #1229563) 1. Fix Leap2a export audio and video file 2. Fix text box leap2a import Change-Id: I6f9f6d082f3796cf74ff134bc632c47e3abf3a63 Signed-off-by: Son Nguyen <s...@catalyst.net.nz> -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1229563 Title: Blocks lost when importing a leap2a from mahara.org Status in Mahara ePortfolio: Fix Released Status in Mahara 1.7 series: Fix Released Bug description: When I export my account from mahara.org to a leap2a file, and then try to import it into a clean Mahara 1.7 installation, I find that it creates all the pages, but some of the Pages are missing their blocks, or their block content. The problem seems to be because it's processing the leap.xml file sequentially from top to bottom. The artefacts that cause problems are listed further down in the XML file than the View they are used in. When the View is processed, it can't find the artefacts, and so it drops their blocks. Leap2a import should be fully backwards-compatible, and it should definitely work with Leap2a files from mahara.org itself, given how prominent a site that is. The solution would seem to be to come up with some way to make it less dependent upon the order that the items are in the XML file. Perhaps more cacheing, so that it doesn't have to map in the leap2a-IDs to real ones until the very end? Or maybe just cache the ones that have an ID that it isn't able to resolve? I suspect this will not be a trivial issue to fix. The simplest thing we can do is to change our export format so that it puts artefacts first, but that won't solve for backwards compatibility. We should also take care that any solution is at least somewhat cross-platform compatible. So, for instance, parsing out all those that have a <mahara:artefactplugin> first, would probably be a bad idea because that's a Mahara extension to leap2a and won't solve this problem for leap2a's coming from other sources. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1229563/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
