Reviewed: https://reviews.mahara.org/6908 Committed: https://git.mahara.org/mahara/mahara/commit/9754e8d3b221c19f19f545338e9e8727a9aa82d0 Submitter: Aaron Wells (aar...@catalyst.net.nz) Branch: 16.04_STABLE
commit 9754e8d3b221c19f19f545338e9e8727a9aa82d0 Author: Aaron Wells <aar...@catalyst.net.nz> Date: Mon Aug 22 12:34:26 2016 +1200 Bug 1615280: More robust email validation Because all of our emails need to pass PHPMailer's validation method before they get sent (due to the way PHPMailer is written) it makes the most sense to use that for validation. Change-Id: I232ab9496ce8fc295a49625c999b48215305216c behatnotneeded: Covered by phpunit (cherry picked from commit 1192c05d2a316dcb4f45cbca28b5a6f1f6acfdac) -- You received this bug notification because you are a member of Mahara Contributors, which is subscribed to Mahara. Matching subscriptions: Subscription for all Mahara Contributors -- please ask on #mahara-dev or mahara.org forum before editing or unsubscribing it! https://bugs.launchpad.net/bugs/1615280 Title: Email validation rejects top-level domains longer than 4 characters Status in Mahara: Fix Committed Status in Mahara 15.04 series: Won't Fix Status in Mahara 15.10 series: Won't Fix Status in Mahara 16.04 series: Fix Committed Status in Mahara 16.10 series: Fix Committed Bug description: This one has existed since 2006, but only become an issue with the opening up of TLDs over the past few years. (https://en.wikipedia.org/wiki/List_of_Internet_top-level_domains) Currently the email validation in pieform limits the TLD to between 2-4 characters (see pieform_rule_email() in htdocs/lib/pieforms/pieform/rules/email.php.) That means people from .horse, for example, can't register. Changing the regex fixed my immediate problem, haven't tested how the other email validation points react. They use FILTER_VALIDATE_EMAIL and PHPMailer::ValidateAddress, so might be better. To manage notifications about this bug go to: https://bugs.launchpad.net/mahara/+bug/1615280/+subscriptions _______________________________________________ Mailing list: https://launchpad.net/~mahara-contributors Post to : mahara-contributors@lists.launchpad.net Unsubscribe : https://launchpad.net/~mahara-contributors More help : https://help.launchpad.net/ListHelp
