Дилян Палаузов writes:
> removing the dependency of jQuery in django-mailman3, Postorius and
> maybe in Hyperkitty will allow Postorius to load faster in browsers
This is true, and generally a good idea. However, it is commonly true
that browsers cache this code, and users keep these pages open for a
long time. To the extent you have open pages and/or cached code, the
benefit is less. I don't recall hearing that page loading delay is a
common issue.
The changes in your 5 MRs are quite small. I suppose the use of
jQuery is quite extensive though. How much code to you expect to
delete and add to completely remove the jQuery dependency from
Postorius? From HyperKitty?
jQuery is a well-known idiom, and provides a lot of features. Which
brings up two questions:
1. Would jQuery-based code be significantly easier to maintain, eg,
by new developers who don't necessarily know Mailman but do know
both js and jQuery?
2. Is there jQuery functionality that we might want to use that would
be more complex than the code in the merge_requests you have
already?
> I think as next somebody should review the above changes, e.g. try
> to deploy them locally and state, that the modified code is
> executed, while the behaviour (program logic) does not change.
I'm really not qualified to do this review (especially the issue of
whether there might be behavior changes). I'm not sure if Mark or
Abhilash is much better able to do so, although I know Abhilash has
worked on the Django apps quite a bit and probably on the js parts.
--
GNU Mailman consultant (installation, migration, customization)
Sirius Open Source https://www.siriusopensource.com/
Software systems consulting in Europe, North America, and Japan
_______________________________________________
Mailman-Developers mailing list -- [email protected]
To unsubscribe send an email to [email protected]
https://mail.python.org/mailman3/lists/mailman-developers.python.org/
Mailman FAQ: https://wiki.list.org/x/AgA3
Security Policy: https://wiki.list.org/x/QIA9
