On Tue, Oct 01, 2013 at 07:52:02PM +0300, Eli Zaretskii wrote:
>> From: Paul Smith <psm...@gnu.org>
>> Cc: bug-...@denis-excoffier.org, pavel_fe...@mail.ru, make-w32@gnu.org
>> Date: Tue, 01 Oct 2013 01:08:32 -0400
>>
>> On Mon, 2013-09-30 at 18:15 +0300, Eli Zaretskii wrote:
>> > I suggest another RC, I think the changes since the last one are
>> > non-trivial.
>>
>> OK, I created a new RC, available now on make-alpha.
>
>Thanks. It still builds fine on Windows using MinGW GCC.
>
>> I don't personally plan to make any more changes, so as soon as you feel
>> you're happy with the Windows support I will release.
>
>Here's the patch for $abspath that should fix the Cygwin build. Would
>Cygwin people please test it, and in particular see if the related
>failures in the test suite are gone? I don't have a Cygwin
>environment to even compile with Cygwin.
>
>I'd especially appreciate if Chris could at least eyeball the patch.
>
>@@ -2001,13 +2005,17 @@ abspath (const char *name, char *apath)
> }
> else
> {
>+#ifdef __CYGWIN__
>+ if (STOP_SET (name[0], MAP_PATHSEP))
>+ root_len = 1;
>+#endif
I've eyeballed the patch even though I won't be releasing a version of
make which has this turned on.
I think the above unnecessary if HAVE_DOS_PATHS is true and should be
#if defined(__CYGWIN__) && defined(HAVE_DOS_PATHS)
I'm not sure it's correct to consider \a to be an absolute path in the
same way that /a is since they mean different things to Cygwin but I
guess that's not something that I have to worry about.
cgf
_______________________________________________
Make-w32 mailing list
Make-w32@gnu.org
https://lists.gnu.org/mailman/listinfo/make-w32
