On Thu, Oct 03, 2013 at 07:05:42PM +0300, Eli Zaretskii wrote: >> Date: Thu, 3 Oct 2013 01:23:15 -0400 >> From: Christopher Faylor <cgf-use-the-mailinglist-ple...@gnu.org> >> >> >@@ -2001,13 +2005,17 @@ abspath (const char *name, char *apath) >> > } >> > else >> > { >> >+#ifdef __CYGWIN__ >> >+ if (STOP_SET (name[0], MAP_PATHSEP)) >> >+ root_len = 1; >> >+#endif >> >> I've eyeballed the patch even though I won't be releasing a version of >> make which has this turned on. >> >> I think the above unnecessary if HAVE_DOS_PATHS is true and should be >> >> #if defined(__CYGWIN__) && defined(HAVE_DOS_PATHS) > >You are right, I pushed a fix.
You got it even with my garbled sentence. Thanks. >> I'm not sure it's correct to consider \a to be an absolute path in the >> same way that /a is since they mean different things to Cygwin but I >> guess that's not something that I have to worry about. > >I thought about that as well. I actually think that Cygwin should not >consider a backslash as a directory separator, even if HAVE_DOS_PATHS >is defined. What do you think? Hmm. I'm not sure. It wouldn't bother me but there may be people who want to be able to use backslashes. >Anyway, such a change modifies behavior (under HAVE_DOS_PATHS), and >its prerequisite is to use STOP_SET everywhere in Make. So I think I >will make that change after the release (unless you, or someone else >object). Sounds good. cgf _______________________________________________ Make-w32 mailing list Make-w32@gnu.org https://lists.gnu.org/mailman/listinfo/make-w32