----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/885/#review806 -----------------------------------------------------------
src/java/org/apache/hadoop/mapreduce/JobSubmitter.java <https://reviews.apache.org/r/885/#comment1758> nit: the javadoc style guide says this should be: @param job the job to check for (so it formats nicely) src/java/org/apache/hadoop/mapreduce/JobSubmitter.java <https://reviews.apache.org/r/885/#comment1759> I'm generally against putting empty @throws in JavaDoc - it doesn't tell you anything the method signature doesn't already say. I'd just delete these lines src/java/org/apache/hadoop/mapreduce/JobSubmitter.java <https://reviews.apache.org/r/885/#comment1760> same comments apply src/java/org/apache/hadoop/mapreduce/JobSubmitter.java <https://reviews.apache.org/r/885/#comment1761> rather than this "note" why not just change the above line to "Checks if the map-output key and value classes have serializers and deserializers associated with them."? src/java/org/apache/hadoop/mapreduce/JobSubmitter.java <https://reviews.apache.org/r/885/#comment1762> missing a space in this exception method. src/test/mapred/org/apache/hadoop/mapreduce/TestMRJobClient.java <https://reviews.apache.org/r/885/#comment1763> add an assert that e.getMessage().contains("Couldn't find a serializer") perhaps? - Todd On 2011-06-11 22:16:24, Harsh Chouraria wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/885/ > ----------------------------------------------------------- > > (Updated 2011-06-11 22:16:24) > > > Review request for hadoop-mapreduce. > > > Summary > ------- > > As discussed on HADOOP-7328, MapReduce can handle serializers in a much > better way in case of bad configuration, improper imports (Some odd Text > class instead of the Writable Text set as key), etc.. > > This issue covers the MapReduce parts of the improvements (made to > MapOutputBuffer and possible early-check of serializer availability > pre-submit) that provide more information than just an NPE as is the current > case. > > > This addresses bug MAPREDUCE-2584. > http://issues.apache.org/jira/browse/MAPREDUCE-2584 > > > Diffs > ----- > > src/java/org/apache/hadoop/mapred/MapTask.java 21599c2 > src/java/org/apache/hadoop/mapreduce/JobSubmitter.java 751d528 > src/test/mapred/org/apache/hadoop/mapreduce/TestMRJobClient.java 5fa329a > > Diff: https://reviews.apache.org/r/885/diff > > > Testing > ------- > > Added a test case that expects a failure if no io.serializers are present. > > > Thanks, > > Harsh > >
