> On 2011-06-12 04:39:03, Todd Lipcon wrote: > > src/java/org/apache/hadoop/mapreduce/JobSubmitter.java, line 471 > > <https://reviews.apache.org/r/885/diff/2/?file=21008#file21008line471> > > > > ah, I noticed one more thing. This catch clause is only for the > > exceptions you've thrown above. > > > > Rather than do the two nested exceptions, better to have just one layer > > of exceptions. You could move the generic instructions from the lower > > exception to a constant and then just append it to either of the two more > > specific methods above.
Fixed. Unable to run tests right now locally due to a missing protobuf class (which is fixed, but I don't seem to have the fresh jar pulled yet in my maven2 cache). Will update the test when it works (and if it does not). - Harsh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://reviews.apache.org/r/885/#review808 ----------------------------------------------------------- On 2011-06-12 14:00:13, Harsh J wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://reviews.apache.org/r/885/ > ----------------------------------------------------------- > > (Updated 2011-06-12 14:00:13) > > > Review request for hadoop-mapreduce. > > > Summary > ------- > > As discussed on HADOOP-7328, MapReduce can handle serializers in a much > better way in case of bad configuration, improper imports (Some odd Text > class instead of the Writable Text set as key), etc.. > > This issue covers the MapReduce parts of the improvements (made to > MapOutputBuffer and possible early-check of serializer availability > pre-submit) that provide more information than just an NPE as is the current > case. > > > This addresses bug MAPREDUCE-2584. > http://issues.apache.org/jira/browse/MAPREDUCE-2584 > > > Diffs > ----- > > src/java/org/apache/hadoop/mapred/MapTask.java 21599c2 > src/java/org/apache/hadoop/mapreduce/JobSubmitter.java 751d528 > src/test/mapred/org/apache/hadoop/mapreduce/TestMRJobClient.java 5fa329a > > Diff: https://reviews.apache.org/r/885/diff > > > Testing > ------- > > Added a test case that expects a failure if no io.serializers are present. > > > Thanks, > > Harsh > >
