[ 
https://issues.apache.org/jira/browse/MAPREDUCE-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12731879#action_12731879
 ] 

rahul k singh commented on MAPREDUCE-766:
-----------------------------------------

Changes look good to me 
A few very minor changes:

1.Change comment in JobSubmissionProtocol "encapsulates blacklist reasons and 
report"
to "encapsulates reasons and report for blacklisted node."

2.ClusterStatus
In getHostName method change comment  @return "tracker name" should be 
"hostname"
toString() method use StringBuilder instead of StringBuffer.
In method setHostName in comment @param need to be changed frmo trackerName to 
hostName.

3.JobClient.
In listBlackListedTrackers.
can we change header like below.
BlackListedNode  Reason Report 

4.TestTaskTrackerBlackListing.
Add comments to testcase.

> Enhance -list-blacklisted-trackers to display host name, blacklisted reason 
> and blacklist report.
> -------------------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-766
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-766
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>            Reporter: Sreekanth Ramakrishnan
>            Assignee: Sreekanth Ramakrishnan
>         Attachments: mapreduce-766-1.patch
>
>
> Currently, the -list-blacklisted-trackers in the mapred job option list only 
> tracker name. We should enhance it to display as hostname, reason for 
> blacklisting and blacklist report.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to