[
https://issues.apache.org/jira/browse/MAPREDUCE-766?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12734183#action_12734183
]
Hemanth Yamijala commented on MAPREDUCE-766:
--------------------------------------------
Looking good. A few minor points:
- We are changing the way we print information about blacklisted trackers. Does
this need to be backwards compatible ? Similarly, maybe we need not deprecate
getBlacklistedTrackerNames()
- The print format should be parse friendly. We are adding white space to
separate reasons for blacklisting and the report can have newlines. These will
make it difficult to parse. Can we make these comma separated ?
- getBlackListedTracker should be getBlackListedTrackers. Similarly
getBlackListedTrackerInfo() should be getBlackListedTrackersInfo() - the former
seems like it is for a specific tracker.
- The test class is not applying, possibly due to the commit of MAPREDUCE-682.
Also, can you enhance the test case to test for a condition when no nodes are
blacklisted, and when there is more than one reason to blacklist ? Maybe one of
the trackers can be blacklisted for more than one reason.
> Enhance -list-blacklisted-trackers to display host name, blacklisted reason
> and blacklist report.
> -------------------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-766
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-766
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Reporter: Sreekanth Ramakrishnan
> Assignee: Sreekanth Ramakrishnan
> Attachments: mapreduce-766-1.patch, mapreduce-766-2.patch,
> mapreduce-766-3.patch
>
>
> Currently, the -list-blacklisted-trackers in the mapred job option list only
> tracker name. We should enhance it to display as hostname, reason for
> blacklisting and blacklist report.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
