[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12832919#action_12832919
 ] 

Hemanth Yamijala commented on MAPREDUCE-1476:
---------------------------------------------

So, just to be sure - the patch is going to attempt commit of a task *only* for 
true Map/Reduce tasks. Job setup/cleanup and task cleanup all cannot rely on a 
commit action at all. As this is a change in semantics of tasks, I wanted to 
call this out specifically, though I feel this is fine. Any objections to this 
from anyone ?

> committer.needsTaskCommit should not be called for a task cleanup attempt
> -------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-1476
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1476
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>    Affects Versions: 0.20.1
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Amareshwari Sriramadasu
>             Fix For: 0.22.0
>
>         Attachments: patch-1476.txt
>
>
> Currently, Task.done() calls committer.needsTaskCommit() to know whether it 
> needs a commit or not. This need not be called for task cleanup attempt as no 
> commit is required for a cleanup attempt. 
> Due to MAPREDUCE-1409, we saw a case where cleanup attempt went into 
> COMMIT_PENDING state.

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to