[
https://issues.apache.org/jira/browse/MAPREDUCE-1476?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Hemanth Yamijala updated MAPREDUCE-1476:
----------------------------------------
Attachment: patch-1476-1.txt
Code changes look good. Unfortunately, I did not understand the test case fully
to comment on it. I did notice though that we are testing the scenario only for
task cleanup, while I suppose we do need to test for job setup and cleanup as
well. I wonder if a more thorough unit test would be enabled if we refactor the
logic of deciding if commit is required into a separate method and directly
test that method with all types of tasks. I created such a method and some
tests in the attached patch. Does this make sense ?
> committer.needsTaskCommit should not be called for a task cleanup attempt
> -------------------------------------------------------------------------
>
> Key: MAPREDUCE-1476
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1476
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Affects Versions: 0.20.1
> Reporter: Amareshwari Sriramadasu
> Assignee: Amareshwari Sriramadasu
> Fix For: 0.22.0
>
> Attachments: patch-1476-1.txt, patch-1476.txt
>
>
> Currently, Task.done() calls committer.needsTaskCommit() to know whether it
> needs a commit or not. This need not be called for task cleanup attempt as no
> commit is required for a cleanup attempt.
> Due to MAPREDUCE-1409, we saw a case where cleanup attempt went into
> COMMIT_PENDING state.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
