[
https://issues.apache.org/jira/browse/MAPREDUCE-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12851999#action_12851999
]
Konstantin Boudnik commented on MAPREDUCE-1646:
-----------------------------------------------
Patch looks mostly good. Except a couple of nits:
- uses a mix of JUnit v3 and v4 APIs, i.e.
{noformat}
+import junit.framework.Assert;
+import org.junit.BeforeClass;
+import org.junit.AfterClass;
+import org.junit.Test;
{noformat}
- indentation isn't uniformed and is anywhere from 1 to 14 spaces (!!!)
{noformat}
+ if (taskInfo.getTaskStatus()[0].getRunState()
+ == TaskStatus.State.RUNNING) {
+ break;
...
+ if (!taskinfo.isSetupOrCleanup()) {
+ taskInfo = taskinfo;
...
+ while (counter < 60) {
+ if (jInfo.getStatus().getRunState() == JobStatus.RUNNING) {
+ break;
+ } else {
+ UtilsForTests.waitFor(1000);
+ jInfo = wovenClient.getJobInfo(id);
+ }
{noformat}
- seems like the LOG statement is out of place:
{noformat}
+ while (!jInfo.getStatus().isJobComplete()) {
+ UtilsForTests.waitFor(100);
+ jInfo = wovenClient.getJobInfo(id);
+ }
+ LOG.info("Waiting till the job is completed...");
{noformat}
Or the the message has to be changed to "The job is completed".
> Task Killing tests
> ------------------
>
> Key: MAPREDUCE-1646
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1646
> Project: Hadoop Map/Reduce
> Issue Type: Task
> Components: test
> Reporter: Vinay Kumar Thota
> Attachments: TaskKilling_1646.patch
>
>
> The following tasks covered in the test.
> 1. In a running job, kill a task and verify the job succeeds.
> 2. Setup a job with long running tasks that write some output to HDFS. When
> one of the tasks is running, ensure that
> the output/_temporary/_attempt-id directory is created. Kill the task. After
> the task is killed, make sure that the
> output/_temporary/_attempt-id directory is cleaned up.
> 3. Setup a job with long running tasks that write some output to HDFS. When
> one of the tasks is running, ensure that
> the output/_temporary/_attempt-id directory is created. Fail the task by
> simulating the map. After the task is failed,
> make sure that the output/_temporary/_attempt-id directory is cleaned up. The
> important difference we are trying to
> check is btw kill and fail, there would a subtle difference.
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
