[ https://issues.apache.org/jira/browse/MAPREDUCE-1646?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12853343#action_12853343 ]
Vinay Kumar Thota commented on MAPREDUCE-1646: ---------------------------------------------- You are absolutely true, I have an issue with IDE configuration.Even If i set the tab size 2 and aligning the code accordingly, but it reformatting the code while generating the patch file so that you are seeing the indentation issues.Now I have given the spaces instead of tabs so that it behaves correctly across the IDE's. I hope this time you won't find any indentation issues in the latest patch. also, I've tried to run it and it failed (see attached log) Vinay: I have run all 3 tests on multi cluster couple of times and I didn't see any issues and all the tests are passing consistently.Please check the attached log file. I have checked your log file and the first test(testFailedTaskJobStatus ) failed due to task has not been started for almost 1 min, so it got failed.And the other two tests are failing due to error in configuration object. I am suspecting the failures might occurred due to environmental issue. One more thing: the class has about 10 unused import statement. Please optimize the import list. Vinay : I have optimized the import list. > Task Killing tests > ------------------ > > Key: MAPREDUCE-1646 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-1646 > Project: Hadoop Map/Reduce > Issue Type: Task > Components: test > Reporter: Vinay Kumar Thota > Assignee: Vinay Kumar Thota > Attachments: TaskKilling_1646.patch, TaskKilling_1646.patch, > TEST-org.apache.hadoop.mapred.TestTaskKilling.txt > > > The following tasks covered in the test. > 1. In a running job, kill a task and verify the job succeeds. > 2. Setup a job with long running tasks that write some output to HDFS. When > one of the tasks is running, ensure that > the output/_temporary/_attempt-id directory is created. Kill the task. After > the task is killed, make sure that the > output/_temporary/_attempt-id directory is cleaned up. > 3. Setup a job with long running tasks that write some output to HDFS. When > one of the tasks is running, ensure that > the output/_temporary/_attempt-id directory is created. Fail the task by > simulating the map. After the task is failed, > make sure that the output/_temporary/_attempt-id directory is cleaned up. The > important difference we are trying to > check is btw kill and fail, there would a subtle difference. -- This message is automatically generated by JIRA. - You can reply to this email to add a comment to the issue online.