[
https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12888212#action_12888212
]
Amar Kamat commented on MAPREDUCE-1925:
---------------------------------------
Few comments
# The patch doesnt contain the changes to the
{{v20-single-input-log-event-classes.text.gz}} file.
# You can get rid of the {{inputLogStream}} variable to avoid future confusion
# You can make the resulting events list and the gold-standard list, in-memory.
Instead of writing the test events into a file ({{result.txt}}) and then
comparing the contents of 2 files ({{result.txt}} and
{{v20-single-input-log-event-classes.text.gz}}) you can keep the contents of
both the files in memory and get rid of {{result.txt}} and
{{v20-single-input-log-event-classes.text.gz}}. The test will be faster and
also easy to change in future.
# If you decide to do the above then there is no need of {{tempDir}} and
{{rootTempDir}}.
> TestRumenJobTraces fails in trunk
> ---------------------------------
>
> Key: MAPREDUCE-1925
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tools/rumen
> Affects Versions: 0.22.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Ravi Gummadi
> Fix For: 0.22.0
>
> Attachments: 1925.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> at
> org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at
> http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
