[ 
https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889757#action_12889757
 ] 

Amar Kamat commented on MAPREDUCE-1925:
---------------------------------------

bq. Invert the order of closing the input stream and returning the the 
decompressor in PossiblyDecompressedInputStream. 
_CodecPool.returnDecompressor()_ internally calls _decompressor.reset()_.  
Wouldn't this also potentially access the underlying I/O stream?

bq. Explicitly make the buffer size and mark limit consistent.
Is this just for the testcase or for the Rumen framework code too?

bq. Move this "Hadoop20JHParser parser = new Hadoop20JHParser(bis);" after 
bis.reset().
Isn't this what Ravi has done? 
{code}
Hadoop20JHParser parser = null;
try {
...
..
bis.reset();
parser = new Hadoop20JHParser(bis);
...
..
}
{code}

> TestRumenJobTraces fails in trunk
> ---------------------------------
>
>                 Key: MAPREDUCE-1925
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: tools/rumen
>    Affects Versions: 0.22.0
>            Reporter: Amareshwari Sriramadasu
>            Assignee: Ravi Gummadi
>             Fix For: 0.22.0
>
>         Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
>       at 
> org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at 
> http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.

Reply via email to