[
https://issues.apache.org/jira/browse/MAPREDUCE-1925?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12889953#action_12889953
]
Hong Tang commented on MAPREDUCE-1925:
--------------------------------------
bq. CodecPool.returnDecompressor() internally calls decompressor.reset().
Wouldn't this also potentially access the underlying I/O stream?
No, Decompressor.reset() clears its state so that it can be reused to
decompress another stream of input. A bug in a similar nature is HADOOP-4195.
bq. I didn't get why these 2 should be same. As default BUFSIZE is 8K, we just
need some number > 8k and the testcase is using 10000. Isn't this OK ? Any
issues ? Just to be on the safer side, if you want it to be increased to a
bigger value like 32K(from 10000), I can do so. Do you see any gain because of
having these 2 same ?
That is fine too. I would even prefer to have the code to reflect the nature
that the buffer size must be no less than the mark limit through something
like: bis.mark(Math.min(BUFSIZE, 10000)).
bq. Can we modify the testcase to make use of RewindableInputStream? Rumen
actually uses RewindableInputStream to take care of this mark/reset business.
That is also fine with me.
bq. This was already incorporated in my latest patch 1925.v1.1.patch.
Thanks!
> TestRumenJobTraces fails in trunk
> ---------------------------------
>
> Key: MAPREDUCE-1925
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-1925
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: tools/rumen
> Affects Versions: 0.22.0
> Reporter: Amareshwari Sriramadasu
> Assignee: Ravi Gummadi
> Fix For: 0.22.0
>
> Attachments: 1925.patch, 1925.v1.1.patch, 1925.v1.patch
>
>
> TestRumenJobTraces failed with following error:
> Error Message
> the gold file contains more text at line 1 expected:<56> but was:<0>
> Stacktrace
> at
> org.apache.hadoop.tools.rumen.TestRumenJobTraces.testHadoop20JHParser(TestRumenJobTraces.java:294)
> Full log of the failure is available at
> http://hudson.zones.apache.org/hudson/job/Mapreduce-Patch-h4.grid.sp2.yahoo.net/292/testReport/org.apache.hadoop.tools.rumen/TestRumenJobTraces/testHadoop20JHParser/
--
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.
