[
https://issues.apache.org/jira/browse/MAPREDUCE-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13048327#comment-13048327
]
jirapos...@reviews.apache.org commented on MAPREDUCE-2584:
----------------------------------------------------------
bq. On 2011-06-12 04:39:03, Todd Lipcon wrote:
bq. > src/java/org/apache/hadoop/mapreduce/JobSubmitter.java, line 471
bq. > <https://reviews.apache.org/r/885/diff/2/?file=21008#file21008line471>
bq. >
bq. > ah, I noticed one more thing. This catch clause is only for the
exceptions you've thrown above.
bq. >
bq. > Rather than do the two nested exceptions, better to have just one
layer of exceptions. You could move the generic instructions from the lower
exception to a constant and then just append it to either of the two more
specific methods above.
Fixed. Unable to run tests right now locally due to a missing protobuf class
(which is fixed, but I don't seem to have the fresh jar pulled yet in my maven2
cache). Will update the test when it works (and if it does not).
- Harsh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/885/#review808
-----------------------------------------------------------
On 2011-06-12 14:00:13, Harsh J wrote:
bq.
bq. -----------------------------------------------------------
bq. This is an automatically generated e-mail. To reply, visit:
bq. https://reviews.apache.org/r/885/
bq. -----------------------------------------------------------
bq.
bq. (Updated 2011-06-12 14:00:13)
bq.
bq.
bq. Review request for hadoop-mapreduce.
bq.
bq.
bq. Summary
bq. -------
bq.
bq. As discussed on HADOOP-7328, MapReduce can handle serializers in a much
better way in case of bad configuration, improper imports (Some odd Text class
instead of the Writable Text set as key), etc..
bq.
bq. This issue covers the MapReduce parts of the improvements (made to
MapOutputBuffer and possible early-check of serializer availability pre-submit)
that provide more information than just an NPE as is the current case.
bq.
bq.
bq. This addresses bug MAPREDUCE-2584.
bq. http://issues.apache.org/jira/browse/MAPREDUCE-2584
bq.
bq.
bq. Diffs
bq. -----
bq.
bq. src/java/org/apache/hadoop/mapred/MapTask.java 21599c2
bq. src/java/org/apache/hadoop/mapreduce/JobSubmitter.java 751d528
bq. src/test/mapred/org/apache/hadoop/mapreduce/TestMRJobClient.java 5fa329a
bq.
bq. Diff: https://reviews.apache.org/r/885/diff
bq.
bq.
bq. Testing
bq. -------
bq.
bq. Added a test case that expects a failure if no io.serializers are present.
bq.
bq.
bq. Thanks,
bq.
bq. Harsh
bq.
bq.
> Check for serializers early, and give out more information regarding missing
> serializers
> ----------------------------------------------------------------------------------------
>
> Key: MAPREDUCE-2584
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2584
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: task
> Affects Versions: 0.20.2
> Reporter: Harsh J
> Assignee: Harsh J
> Labels: serializers, tasks
> Fix For: 0.23.0
>
>
> As discussed on HADOOP-7328, MapReduce can handle serializers in a much
> better way in case of bad configuration, improper imports (Some odd Text
> class instead of the Writable Text set as key), etc..
> This issue covers the MapReduce parts of the improvements (made to IFile,
> MapOutputBuffer, etc. and possible early-check of serializer availability
> pre-submit) that provide more information than just an NPE as is the current
> case.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
