[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2584?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13050380#comment-13050380
 ] 

jirapos...@reviews.apache.org commented on MAPREDUCE-2584:
----------------------------------------------------------


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/885/
-----------------------------------------------------------

(Updated 2011-06-16 12:24:09.519284)


Review request for hadoop-mapreduce.


Changes
-------

IOException catching ('stead of null).


Summary
-------

As discussed on HADOOP-7328, MapReduce can handle serializers in a much better 
way in case of bad configuration, improper imports (Some odd Text class instead 
of the Writable Text set as key), etc..

This issue covers the MapReduce parts of the improvements (made to 
MapOutputBuffer and possible early-check of serializer availability pre-submit) 
that provide more information than just an NPE as is the current case.


This addresses bug MAPREDUCE-2584.
    http://issues.apache.org/jira/browse/MAPREDUCE-2584


Diffs (updated)
-----

  src/java/org/apache/hadoop/mapreduce/JobSubmitter.java 751d528 
  src/test/mapred/org/apache/hadoop/mapreduce/TestMRJobClient.java 5fa329a 

Diff: https://reviews.apache.org/r/885/diff


Testing
-------

Added a test case that expects a failure if no io.serializers are present.


Thanks,

Harsh



> Check for serializers early, and give out more information regarding missing 
> serializers
> ----------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-2584
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2584
>             Project: Hadoop Map/Reduce
>          Issue Type: Improvement
>          Components: task
>    Affects Versions: 0.20.2
>            Reporter: Harsh J
>            Assignee: Harsh J
>              Labels: serializers, tasks
>             Fix For: 0.23.0
>
>         Attachments: MAPREDUCE-2584.r3.diff
>
>
> As discussed on HADOOP-7328, MapReduce can handle serializers in a much 
> better way in case of bad configuration, improper imports (Some odd Text 
> class instead of the Writable Text set as key), etc..
> This issue covers the MapReduce parts of the improvements (made to IFile, 
> MapOutputBuffer, etc. and possible early-check of serializer availability 
> pre-submit) that provide more information than just an NPE as is the current 
> case.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to