[
https://issues.apache.org/jira/browse/MAPREDUCE-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13054467#comment-13054467
]
Vinay Kumar Thota commented on MAPREDUCE-2596:
----------------------------------------------
I have reviewed the patch and few minor comments.
{noformat}
+ @SuppressWarnings("deprecation")
+ public void update(ClusterStats item) {
+ try {
+ numBlacklistedTrackers = item.getStatus().getBlacklistedTrackers();
+ numActiveTrackers = item.getStatus().getTaskTrackers();
+ maxMapTasks = item.getStatus().getMaxMapTasks();
+ maxReduceTasks = item.getStatus().getMaxReduceTasks();
+ } catch (Exception e) {
+ long time = System.currentTimeMillis();
+ LOG.info("Error in processing cluster status at "
+ + FastDateFormat.getInstance().format(time));
+ }
+ }
{noformat}
bq. You can define the above method as static method right,because cluster
information is same for across the jobs in a gridmix run right.
bq. \ No newline at end of file
I think, no newline at end of file will cause an issues while adding the
patch.Make sure to give a space at end of the file.
{noformat}
+ if (job.isSuccessful()) {
+ ++totalSuccessfulJobs;
+ } else {
+ if (job.isComplete()) {
+ ++totalFailedJobs;
+ } else {
+ //TODO Check
+ ++totalSubmitFailedJobs;
+ }
+ }
{noformat}
bq. The above instructions will change to
if(condition){}elseif(conditon){}else{} format right.
bq.Add java doc comments at least for public methods.
> Gridmix should notify job failures
> ----------------------------------
>
> Key: MAPREDUCE-2596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2596
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: benchmarks, contrib/gridmix
> Affects Versions: 0.23.0
> Reporter: Arun C Murthy
> Assignee: Amar Kamat
> Attachments: gridmix-summary-v1.3.patch
>
>
> Gridmix doesn't warn the user if any of the jobs in the mix fail... it
> probably should printout a summary of the jobs and other statistics at the
> end too.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
