[
https://issues.apache.org/jira/browse/MAPREDUCE-2596?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13055327#comment-13055327
]
Amar Kamat commented on MAPREDUCE-2596:
---------------------------------------
Thanks for the review Vinay.
bq. You can define the above method as static method right,because cluster
information is same for across the jobs in a gridmix run right.
I cannot define it as static as the member variables of that class are being
set in the method.
bq. I think, no newline at end of file will cause an issues while adding the
patch.Make sure to give a space at end of the file.
The patch cleanly applies and test-patch passed. I have verified this.
bq. The above instructions will change to
if(condition){}elseif(conditon){}else{} format right.
+1.
bq. Add java doc comments at least for public methods.
I have intentionally not added comments for overridden apis. I will check again
and add the missing ones.
> Gridmix should notify job failures
> ----------------------------------
>
> Key: MAPREDUCE-2596
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2596
> Project: Hadoop Map/Reduce
> Issue Type: Improvement
> Components: benchmarks, contrib/gridmix
> Affects Versions: 0.23.0
> Reporter: Arun C Murthy
> Assignee: Amar Kamat
> Attachments: gridmix-summary-v1.3.patch
>
>
> Gridmix doesn't warn the user if any of the jobs in the mix fail... it
> probably should printout a summary of the jobs and other statistics at the
> end too.
--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira
