[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061778#comment-13061778
 ] 

Hadoop QA commented on MAPREDUCE-2661:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12485693/MAPREDUCE-2661.patch
  against trunk revision 1144097.

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified 
tests.
                        Please justify why no new tests are needed for this 
patch.
                        Also please list what manual steps were performed to 
verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: 
https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/443//console

This message is automatically generated.

> Accessing MapTaskImpl from TaskImpl
> -----------------------------------
>
>                 Key: MAPREDUCE-2661
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>            Priority: Minor
>         Attachments: MAPREDUCE-2661.patch
>
>
> We are directly accessing MapTaskImpl in 
> TaskImpl.InitialScheduleTransition.transition(..). It'll be better to 
> reorganize the code so each subclass can provide its own behavior instead of 
> explicitly checking for the subclass type. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to