[ 
https://issues.apache.org/jira/browse/MAPREDUCE-2661?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062055#comment-13062055
 ] 

Josh Wills commented on MAPREDUCE-2661:
---------------------------------------

+1

An optional thought: add a comment to the definition of the getSplitsAsString() 
method in TaskImpl.java to specify that it will return the empty string for 
reduce tasks since they don't have splits.

> Accessing MapTaskImpl from TaskImpl
> -----------------------------------
>
>                 Key: MAPREDUCE-2661
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-2661
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2
>            Reporter: Ahmed Radwan
>            Assignee: Ahmed Radwan
>            Priority: Minor
>         Attachments: MAPREDUCE-2661.patch
>
>
> We are directly accessing MapTaskImpl in 
> TaskImpl.InitialScheduleTransition.transition(..). It'll be better to 
> reorganize the code so each subclass can provide its own behavior instead of 
> explicitly checking for the subclass type. 

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to