[
https://issues.apache.org/jira/browse/MAPREDUCE-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]
Vinod Kumar Vavilapalli updated MAPREDUCE-2989:
-----------------------------------------------
Status: Open (was: Patch Available)
That was such a monstrous patch! If only I have a rubber hammer to deal you
with..
Anyways, here goes. Looks good overall. Going to trust your testing.
Mostly simple suggestions. Postponing big changes to separate tickets section:
- JobHistoryServer: commented out lines about mapred-site.xml
- TestHSWebApp.testLogView2: Error message can be improved.
- ContainerManagerImpl.handle(): Why special handling of log-finish event.
Can't use ContainerManagerEvent?
- AMStartedEvent.java : constructor >80 chars
- AggregatedLogsBlock: No need for creating ApplicationACLsManager every
single time?
others, for separate tickets. I'd be happy if we create them now itself:
- Move all the Log related stuff to common module.
- Could add offsets etc. for aggregated logs
- Changes similar to HSJobBlock needed for JobBlock listing all AppAttempts so
far.
- Containerlogs url : Passing usernames explicitly is unweildly. We can do
away with this, once we have a clear abstraction of a Log-server.
> JobHistory should link to task logs
> -----------------------------------
>
> Key: MAPREDUCE-2989
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-2989
> Project: Hadoop Map/Reduce
> Issue Type: Sub-task
> Components: mrv2
> Affects Versions: 0.23.0, 0.24.0
> Reporter: Siddharth Seth
> Assignee: Siddharth Seth
> Priority: Critical
> Fix For: 0.23.0
>
> Attachments: MR2989_v1.txt, MR2989_v2.txt, MR2989_v3.txt,
> MR2989_v4.txt
>
>
> The log link on the task attempt page is currently broken - since it relies
> on a ContainerId. We should either pass the containerId via a history event -
> or some kind of field with information about the log location.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
