[ https://issues.apache.org/jira/browse/MAPREDUCE-2989?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
Siddharth Seth updated MAPREDUCE-2989: -------------------------------------- Attachment: MR2989_v5.txt Thanks for the review. Should really have split the patch. bq. JobHistoryServer: commented out lines about mapred-site.xml Removed instead of commenting. bq. TestHSWebApp.testLogView2: Error message can be improved. Fixed. bq. ContainerManagerImpl.handle(): Why special handling of log-finish event. Can't use ContainerManagerEvent? Done via a CMgrEvent. bq. AMStartedEvent.java : constructor >80 chars Fixed bq. AggregatedLogsBlock: No need for creating ApplicationACLsManager every single time? The history service currently does not have an AppAclManager. Can we leave this like this for now, and fix it later when the HistoryService adds it. Added a flag to disable aggregation (defaults to disabled) bq. Could add offsets etc. for aggregated logs Will do this after revising the log storage format to make types easier to find. bq. Changes similar to HSJobBlock needed for JobBlock listing all AppAttempts so far. That could be done - display all previous AM logs on the current AM UI. bq. Passing usernames explicitly is unweildly. Agreed, it's just a hint as to where to look for the logs. At least ACL checks are done correctly after this. > JobHistory should link to task logs > ----------------------------------- > > Key: MAPREDUCE-2989 > URL: https://issues.apache.org/jira/browse/MAPREDUCE-2989 > Project: Hadoop Map/Reduce > Issue Type: Sub-task > Components: mrv2 > Affects Versions: 0.23.0, 0.24.0 > Reporter: Siddharth Seth > Assignee: Siddharth Seth > Priority: Critical > Fix For: 0.23.0 > > Attachments: MR2989_v1.txt, MR2989_v2.txt, MR2989_v3.txt, > MR2989_v4.txt, MR2989_v5.txt > > > The log link on the task attempt page is currently broken - since it relies > on a ContainerId. We should either pass the containerId via a history event - > or some kind of field with information about the log location. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira