[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3398?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13162563#comment-13162563
 ] 

Hitesh Shah commented on MAPREDUCE-3398:
----------------------------------------

assertTrue("Renewal of canceled token didn't fail", false);
  - could be replaced with a fail()

spelling mistake - DelayedTokenCacneller

Should we document that renewal/keep-alive time should always be 2x of node 
heartbeat time? 

Apart from the above minor nits, patch looks good. 

                
> Log Aggregation broken in Secure Mode
> -------------------------------------
>
>                 Key: MAPREDUCE-3398
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3398
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, nodemanager
>    Affects Versions: 0.23.0
>            Reporter: Siddharth Seth
>            Assignee: Siddharth Seth
>            Priority: Critical
>             Fix For: 0.23.1
>
>         Attachments: MR3398_v1.txt
>
>
> Log aggregation in secure mode does not work with MAPREDUCE-2977. The 
> nodemanager relies on the users credentials to write out logs to HDFS. These 
> credentials are currently cancelled once a job completes, before the NM can 
> write out the logs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to