[
https://issues.apache.org/jira/browse/MAPREDUCE-4010?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13230380#comment-13230380
]
Robert Joseph Evans commented on MAPREDUCE-4010:
------------------------------------------------
I personally think that we do want Container.size() to return the same number
of elements as iterator would. If it does not the
serialization/deserialization code is broken. That is what this test is
testing.
{code}
public int size() {
return getProps().size();
}
public void write(DataOutput out) throws IOException {
Properties props = getProps();
WritableUtils.writeVInt(out, props.size());
for(Map.Entry<Object, Object> item: props.entrySet()) {
org.apache.hadoop.io.Text.writeString(out, (String) item.getKey());
org.apache.hadoop.io.Text.writeString(out, (String) item.getValue());
}
}
@Override
public void readFields(DataInput in) throws IOException {
clear();
int size = WritableUtils.readVInt(in);
for(int i=0; i < size; ++i) {
set(org.apache.hadoop.io.Text.readString(in),
org.apache.hadoop.io.Text.readString(in));
}
}
{code}
I am not saying that the code is wrong here. All I am saying is that we should
not fix a test by commenting out assertions until we truly understand the root
cause of the failure.
> TestWritableJobConf fails on trunk
> ----------------------------------
>
> Key: MAPREDUCE-4010
> URL: https://issues.apache.org/jira/browse/MAPREDUCE-4010
> Project: Hadoop Map/Reduce
> Issue Type: Bug
> Components: mrv2
> Affects Versions: 0.24.0
> Reporter: Jason Lowe
> Assignee: Alejandro Abdelnur
> Priority: Critical
> Fix For: 0.23.3
>
> Attachments: MAPREDUCE-4010.patch, MAPREDUCE-4010.patch
>
>
> TestWritableJobConf is currently failing two tests on trunk:
> * testEmptyConfiguration
> * testNonEmptyConfiguration
> Appears to have been caused by HADOOP-8167.
--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators:
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira
