[ 
https://issues.apache.org/jira/browse/MAPREDUCE-3350?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13280165#comment-13280165
 ] 

Thomas Graves commented on MAPREDUCE-3350:
------------------------------------------

{quote}
RMAppAttempt.startTime - should I wait for START event or is constructor fine.
{quote}
I think it would be better when the app gets the START event in 
AttemptStartedTransition.  Make sure an unset value is handled properly.

{quote}
RMApp/RMAppImpl - is there a better way to return the attempts?
{quote}
We should be returning a read only version of attempts.  Perhaps we can create 
the AppAttemptsInfo there to keep from having to copy multiple times.

{quote}
AppAttempInfo - Should the constructor take an RMAppAttempt or individual 
parameters
{quote}
I think its fine as is.

{quote}
TestRMWebServicesApp - Should I combine the app/appattemt tests for compile 
time benefit or keep separate?
{quote}
Personally I would prefer them separate to keep the files reasonable in size 
and split up the functionality so it easier to see what failed, but not a 
blocker either way.

                
> Per-app RM page should have the list of application-attempts like on the app 
> JHS page
> -------------------------------------------------------------------------------------
>
>                 Key: MAPREDUCE-3350
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3350
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv2, webapps
>    Affects Versions: 0.23.0
>            Reporter: Vinod Kumar Vavilapalli
>            Assignee: Jonathan Eagles
>            Priority: Critical
>             Fix For: 0.24.0
>
>         Attachments: MAPREDUCE-3350.patch, MAPREDUCE-3350.patch, 
> MAPREDUCE-3350.patch, MAPREDUCE-3350.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: 
https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Reply via email to